egl: set context version when egl < 1.5 #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Dec 21, 2023
MarijnS95
approved these changes
Dec 21, 2023
|
The commit signoff looks a bit weird, since you (@kchibisov) are both the author and committer. Perhaps this should be a |
|
|
I guess |
|
Oh yeah I forgot C-d-b, that's best! |
kchibisov
force-pushed
the
egl-1.3-set-version
branch
from
ff2aac0 to
6a1daa5
Compare
Yes. Tested the egl-1.3-set-version branch and my tests pass. |
Co-developed-by: p0ryae <[email protected]> Fixes rust-windowing#1647.
kchibisov
force-pushed
the
egl-1.3-set-version
branch
from
6a1daa5 to
840490d
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: p0ryae [email protected]
Fixes #1647.
--
@p0ryae does it fix your issue?